From 56f07e9a3aaa873fe385d224f088f048dbafa8f7 Mon Sep 17 00:00:00 2001 From: bculkin2442 Date: Mon, 10 Apr 2017 16:49:54 -0400 Subject: Cleanup --- JPratt/src/main/java/bjc/pratt/PrattParser.java | 86 ++++++++++++------------- 1 file changed, 42 insertions(+), 44 deletions(-) (limited to 'JPratt/src/main/java/bjc/pratt/PrattParser.java') diff --git a/JPratt/src/main/java/bjc/pratt/PrattParser.java b/JPratt/src/main/java/bjc/pratt/PrattParser.java index c36cabc..b3ce4a7 100644 --- a/JPratt/src/main/java/bjc/pratt/PrattParser.java +++ b/JPratt/src/main/java/bjc/pratt/PrattParser.java @@ -1,28 +1,28 @@ package bjc.pratt; +import java.util.HashMap; +import java.util.Map; + import bjc.pratt.commands.DefaultInitialCommand; import bjc.pratt.commands.DefaultNonInitialCommand; import bjc.utils.data.ITree; import bjc.utils.funcutils.NumberUtils; import bjc.utils.parserutils.ParserException; -import java.util.HashMap; -import java.util.Map; - /** * A configurable Pratt parser for expressions. - * + * * @author EVE - * + * * @param * The key type for the tokens. - * + * * @param * The value type for the tokens. - * + * * @param * The state type of the parser. - * + * * */ public class PrattParser { @@ -35,24 +35,24 @@ public class PrattParser { /* * Left-commands that depend on what the null command was. */ - private Map>> dependantLeftCommands; + private final Map>> dependantLeftCommands; /* * The left commands. */ - private Map> leftCommands; + private final Map> leftCommands; /* * The initial commands. */ - private Map> nullCommands; + private final Map> nullCommands; /* * Initial commands only checked for statements. */ - private Map> statementCommands; + private final Map> statementCommands; /** * Create a new Pratt parser. - * + * */ public PrattParser() { dependantLeftCommands = new HashMap<>(); @@ -64,34 +64,32 @@ public class PrattParser { /** * Parse an expression. - * + * * @param precedence * The initial precedence for the expression. - * + * * @param tokens * The tokens for the expression. - * + * * @param state * The state of the parser. - * + * * @param isStatement * Whether or not to parse statements. - * + * * @return The expression as an AST. - * + * * @throws ParserException * If something goes wrong during parsing. */ - public ITree> parseExpression(int precedence, TokenStream tokens, C state, - boolean isStatement) throws ParserException { - if (precedence < 0) { - throw new IllegalArgumentException("Precedence must be greater than zero"); - } + public ITree> parseExpression(final int precedence, final TokenStream tokens, final C state, + final boolean isStatement) throws ParserException { + if (precedence < 0) throw new IllegalArgumentException("Precedence must be greater than zero"); - Token initToken = tokens.current(); + final Token initToken = tokens.current(); tokens.next(); - K initKey = initToken.getKey(); + final K initKey = initToken.getKey(); ITree> ast; @@ -106,9 +104,9 @@ public class PrattParser { int rightPrec = Integer.MAX_VALUE; while (true) { - Token tok = tokens.current(); + final Token tok = tokens.current(); - K key = tok.getKey(); + final K key = tok.getKey(); NonInitialCommand command = leftCommands.getOrDefault(key, DEFAULT_LEFT_COMMAND); @@ -116,7 +114,7 @@ public class PrattParser { command = dependantLeftCommands.get(initKey).getOrDefault(key, command); } - int leftBind = command.leftBinding(); + final int leftBind = command.leftBinding(); if (NumberUtils.between(precedence, rightPrec, leftBind)) { tokens.next(); @@ -133,63 +131,63 @@ public class PrattParser { /** * Add a non-initial command to this parser. - * + * * @param marker * The key that marks the command. - * + * * @param comm * The command. */ - public void addNonInitialCommand(K marker, NonInitialCommand comm) { + public void addNonInitialCommand(final K marker, final NonInitialCommand comm) { leftCommands.put(marker, comm); } /** * Add a initial command to this parser. - * + * * @param marker * The key that marks the command. - * + * * @param comm * The command. */ - public void addInitialCommand(K marker, InitialCommand comm) { + public void addInitialCommand(final K marker, final InitialCommand comm) { nullCommands.put(marker, comm); } /** * Add a statement command to this parser. - * + * * The difference between statements and initial commands is that * statements can only appear at the start of the expression. - * + * * @param marker * The key that marks the command. - * + * * @param comm * The command. */ - public void addStatementCommand(K marker, InitialCommand comm) { + public void addStatementCommand(final K marker, final InitialCommand comm) { statementCommands.put(marker, comm); } /** * Add a dependent non-initial command to this parser. - * + * * @param dependant * The dependent that precedes the command. - * + * * @param marker * The token key that marks the command. - * + * * @param comm * The command. */ - public void addDependantCommand(K dependant, K marker, NonInitialCommand comm) { + public void addDependantCommand(final K dependant, final K marker, final NonInitialCommand comm) { if (dependantLeftCommands.containsKey(dependant)) { dependantLeftCommands.get(dependant).put(marker, comm); } else { - Map> comms = new HashMap<>(); + final Map> comms = new HashMap<>(); comms.put(marker, comm); -- cgit v1.2.3