general code cleanup

removed some unused classes

Signed-off-by: Giovanni Harting <539@idlegandalf.com>

19 files changed, 10 insertions, 44 deletions

diff --git a/src/main/java/com/sosnitzka/taiga/traits/TraitBerserk.java b/src/main/java/com/sosnitzka/taiga/traits/TraitBerserk.java
index 0410547..8f7085d 100644
--- a/src/main/java/com/sosnitzka/taiga/traits/TraitBerserk.java
+++ b/src/main/java/com/sosnitzka/taiga/traits/TraitBerserk.java
@@ -45,7 +45,6 @@ public class TraitBerserk extends TraitProgressiveStats {
         return newDamage * 4;
     }
 
-
     @Override
     public void onUpdate(ItemStack tool, World world, Entity entity, int itemSlot, boolean isSelected) {
         if (!world.isRemote) {
diff --git a/src/main/java/com/sosnitzka/taiga/traits/TraitBright.java b/src/main/java/com/sosnitzka/taiga/traits/TraitBright.java
index a307c54..093d1cc 100644
--- a/src/main/java/com/sosnitzka/taiga/traits/TraitBright.java
+++ b/src/main/java/com/sosnitzka/taiga/traits/TraitBright.java
@@ -31,7 +31,6 @@ public class TraitBright extends AbstractTrait {
         return super.damage(tool, player, target, damage, newDamage, isCritical);
     }
 
-
     @Override
     public void afterBlockBreak(ItemStack tool, World world, IBlockState state, BlockPos pos, EntityLivingBase
             player, boolean wasEffective) {
diff --git a/src/main/java/com/sosnitzka/taiga/traits/TraitCatcher.java b/src/main/java/com/sosnitzka/taiga/traits/TraitCatcher.java
index e84f2fc..dcf4f99 100644
--- a/src/main/java/com/sosnitzka/taiga/traits/TraitCatcher.java
+++ b/src/main/java/com/sosnitzka/taiga/traits/TraitCatcher.java
@@ -64,7 +64,6 @@ public class TraitCatcher extends AbstractTrait {
         }
     }
 
-
     @Override
     public void onUpdate(ItemStack tool, World world, Entity entity, int itemSlot, boolean isSelected) {
         if (!world.isRemote) {
@@ -77,7 +76,6 @@ public class TraitCatcher extends AbstractTrait {
         }
     }
 
-
     @SubscribeEvent
     public void onRightClickItem(PlayerInteractEvent.RightClickItem event) {
         World w = event.getWorld();
diff --git a/src/main/java/com/sosnitzka/taiga/traits/TraitCongenial.java b/src/main/java/com/sosnitzka/taiga/traits/TraitCongenial.java
index 21ac249..b3c6194 100644
--- a/src/main/java/com/sosnitzka/taiga/traits/TraitCongenial.java
+++ b/src/main/java/com/sosnitzka/taiga/traits/TraitCongenial.java
@@ -20,8 +20,6 @@ import slimeknights.tconstruct.library.utils.TinkerUtil;
 
 
 public class TraitCongenial extends AbstractTrait {
-
-
     public TraitCongenial() {
         super(TraitCongenial.class.getSimpleName().toLowerCase().substring(5), TextFormatting.RED);
         MinecraftForge.EVENT_BUS.register(this);
diff --git a/src/main/java/com/sosnitzka/taiga/traits/TraitCrushing.java b/src/main/java/com/sosnitzka/taiga/traits/TraitCrushing.java
index e88640d..e66b80c 100644
--- a/src/main/java/com/sosnitzka/taiga/traits/TraitCrushing.java
+++ b/src/main/java/com/sosnitzka/taiga/traits/TraitCrushing.java
@@ -13,7 +13,6 @@ public class TraitCrushing extends AbstractTrait {
         super(TraitCrushing.class.getSimpleName().toLowerCase().substring(5), TextFormatting.GRAY);
     }
 
-
     @Override
     public void blockHarvestDrops(ItemStack tool, BlockEvent.HarvestDropsEvent e) {
         if (!e.getWorld().isRemote) {
diff --git a/src/main/java/com/sosnitzka/taiga/traits/TraitCursed.java b/src/main/java/com/sosnitzka/taiga/traits/TraitCursed.java
index a0a1444..fa8af29 100644
--- a/src/main/java/com/sosnitzka/taiga/traits/TraitCursed.java
+++ b/src/main/java/com/sosnitzka/taiga/traits/TraitCursed.java
@@ -20,8 +20,6 @@ import slimeknights.tconstruct.library.utils.TinkerUtil;
 
 public class TraitCursed extends AbstractTrait {
 
-    private static int chance = 60 * 1000;
-
     public TraitCursed() {
         super(TraitCursed.class.getSimpleName().toLowerCase().substring(5), TextFormatting.RED);
         MinecraftForge.EVENT_BUS.register(this);
@@ -31,6 +29,7 @@ public class TraitCursed extends AbstractTrait {
     public void onUpdate(ItemStack tool, World world, Entity entity, int itemSlot, boolean isSelected) {
         NBTTagCompound tag = TagUtil.getExtraTag(tool);
         Utils.GeneralNBTData data = Utils.GeneralNBTData.read(tag);
+        int chance = 60 * 1000;
         if (random.nextInt((chance + data.curse) / (data.curse + 1)) == 1) {
             if (isSelected) data.curse += 10;
             else data.curse++;
diff --git a/src/main/java/com/sosnitzka/taiga/traits/TraitDecay.java b/src/main/java/com/sosnitzka/taiga/traits/TraitDecay.java
index 3445672..a1d1a57 100644
--- a/src/main/java/com/sosnitzka/taiga/traits/TraitDecay.java
+++ b/src/main/java/com/sosnitzka/taiga/traits/TraitDecay.java
@@ -62,16 +62,7 @@ public class TraitDecay extends TraitProgressiveStats {
 
     @Override
     public void onUpdate(ItemStack tool, World world, Entity entity, int itemSlot, boolean isSelected) {
-        if (entity instanceof FakePlayer || entity.world.isRemote) {
-            return;
-        }
-        // every 3.6 seconds we distribute one stat. This means 1h = 1000 applications
-        if (entity.ticksExisted % TICK_PER_STAT > 0) {
-            return;
-        }
-
-        // we don't update if the player is currently breaking a block because that'd reset it
-        if (playerIsBreakingBlock(entity)) {
+        if (entity instanceof FakePlayer || entity.world.isRemote || entity.ticksExisted % TICK_PER_STAT != 0 || playerIsBreakingBlock(entity)) {
             return;
         }
 
diff --git a/src/main/java/com/sosnitzka/taiga/traits/TraitDissolving.java b/src/main/java/com/sosnitzka/taiga/traits/TraitDissolving.java
index ac8a213..0cded7c 100644
--- a/src/main/java/com/sosnitzka/taiga/traits/TraitDissolving.java
+++ b/src/main/java/com/sosnitzka/taiga/traits/TraitDissolving.java
@@ -18,7 +18,6 @@ public class TraitDissolving extends AbstractTrait {
     }
 
     // high chance to remove XP, low chance to double,triple or quatruple dropped Experience
-
     @SubscribeEvent
     public void onXpDrop(LivingExperienceDropEvent event) {
         if (!event.getEntity().getEntityWorld().isRemote) {
diff --git a/src/main/java/com/sosnitzka/taiga/traits/TraitGlimmer.java b/src/main/java/com/sosnitzka/taiga/traits/TraitGlimmer.java
index 92c60f8..6b5b01f 100644
--- a/src/main/java/com/sosnitzka/taiga/traits/TraitGlimmer.java
+++ b/src/main/java/com/sosnitzka/taiga/traits/TraitGlimmer.java
@@ -16,7 +16,6 @@ import slimeknights.tconstruct.library.utils.TinkerUtil;
 
 public class TraitGlimmer extends AbstractTrait {
 
-
     public TraitGlimmer() {
         super("glimmer", TextFormatting.DARK_GRAY);
     }
diff --git a/src/main/java/com/sosnitzka/taiga/traits/TraitInstable.java b/src/main/java/com/sosnitzka/taiga/traits/TraitInstable.java
index d023f41..be336f7 100644
--- a/src/main/java/com/sosnitzka/taiga/traits/TraitInstable.java
+++ b/src/main/java/com/sosnitzka/taiga/traits/TraitInstable.java
@@ -21,6 +21,7 @@ import slimeknights.tconstruct.library.utils.ToolHelper;
 
 
 public class TraitInstable extends AbstractTrait {
+
     public TraitInstable() {
         super("instable", TextFormatting.DARK_RED);
         MinecraftForge.EVENT_BUS.register(this);
diff --git a/src/main/java/com/sosnitzka/taiga/traits/TraitMutate.java b/src/main/java/com/sosnitzka/taiga/traits/TraitMutate.java
index 6830cda..8ebb077 100644
--- a/src/main/java/com/sosnitzka/taiga/traits/TraitMutate.java
+++ b/src/main/java/com/sosnitzka/taiga/traits/TraitMutate.java
@@ -15,6 +15,7 @@ import static com.google.common.collect.Lists.newArrayList;
 
 
 public class TraitMutate extends AbstractTrait {
+
     public TraitMutate() {
         super(TraitMutate.class.getSimpleName().toLowerCase().substring(5), TextFormatting.YELLOW);
         MinecraftForge.EVENT_BUS.register(this);
@@ -33,7 +34,6 @@ public class TraitMutate extends AbstractTrait {
                 event.setCanceled(true);
                 event.getWorld().setBlockState(event.getPos(), newState);
             }
-
         }
     }
 }
diff --git a/src/main/java/com/sosnitzka/taiga/traits/TraitNatureBound.java b/src/main/java/com/sosnitzka/taiga/traits/TraitNatureBound.java
index c9a0313..53f4d86 100644
--- a/src/main/java/com/sosnitzka/taiga/traits/TraitNatureBound.java
+++ b/src/main/java/com/sosnitzka/taiga/traits/TraitNatureBound.java
@@ -12,6 +12,7 @@ import slimeknights.tconstruct.library.utils.ToolHelper;
 
 
 public class TraitNatureBound extends AbstractTrait {
+
     public TraitNatureBound() {
         super("naturebound", TextFormatting.GREEN);
         MinecraftForge.EVENT_BUS.register(this);
diff --git a/src/main/java/com/sosnitzka/taiga/traits/TraitPorted.java b/src/main/java/com/sosnitzka/taiga/traits/TraitPorted.java
index ca95f04..c44b754 100644
--- a/src/main/java/com/sosnitzka/taiga/traits/TraitPorted.java
+++ b/src/main/java/com/sosnitzka/taiga/traits/TraitPorted.java
@@ -19,6 +19,7 @@ import slimeknights.tconstruct.library.utils.ToolHelper;
 
 
 public class TraitPorted extends AbstractTrait {
+
     public static int distance = 10;
 
     public TraitPorted() {
@@ -42,7 +43,6 @@ public class TraitPorted extends AbstractTrait {
         }
     }
 
-
     @Override
     public void afterHit(ItemStack tool, EntityLivingBase player, EntityLivingBase target, float damage, boolean
             wasCritical, boolean wasHit) {
diff --git a/src/main/java/com/sosnitzka/taiga/traits/TraitProgressiveStats.java b/src/main/java/com/sosnitzka/taiga/traits/TraitProgressiveStats.java
index d9af33d..445e931 100644
--- a/src/main/java/com/sosnitzka/taiga/traits/TraitProgressiveStats.java
+++ b/src/main/java/com/sosnitzka/taiga/traits/TraitProgressiveStats.java
@@ -29,13 +29,6 @@ public abstract class TraitProgressiveStats extends AbstractTrait {
         applied_key = identifier + "StatBonus";
     }
 
-    public TraitProgressiveStats(String identifier, int color) {
-        super(identifier, color);
-
-        pool_key = identifier + "StatPool";
-        applied_key = identifier + "StatBonus";
-    }
-
     /* Modifier management */
 
     protected static StatNBT getStats(NBTTagCompound root, String key) {
diff --git a/src/main/java/com/sosnitzka/taiga/traits/TraitResonance.java b/src/main/java/com/sosnitzka/taiga/traits/TraitResonance.java
index c4e41dd..b46f2aa 100644
--- a/src/main/java/com/sosnitzka/taiga/traits/TraitResonance.java
+++ b/src/main/java/com/sosnitzka/taiga/traits/TraitResonance.java
@@ -7,7 +7,6 @@ import slimeknights.tconstruct.library.traits.AbstractTrait;
 
 public class TraitResonance extends AbstractTrait {
 
-
     public static float chance = 0.33f;
 
     public TraitResonance() {
diff --git a/src/main/java/com/sosnitzka/taiga/traits/TraitReviving.java b/src/main/java/com/sosnitzka/taiga/traits/TraitReviving.java
index 1f48b57..297b4fd 100644
--- a/src/main/java/com/sosnitzka/taiga/traits/TraitReviving.java
+++ b/src/main/java/com/sosnitzka/taiga/traits/TraitReviving.java
@@ -18,7 +18,6 @@ import slimeknights.tconstruct.library.utils.TinkerUtil;
 
 public class TraitReviving extends AbstractTrait {
 
-
     public final float chance = 0.15f;
 
     public TraitReviving() {
diff --git a/src/main/java/com/sosnitzka/taiga/traits/TraitSlaughtering.java b/src/main/java/com/sosnitzka/taiga/traits/TraitSlaughtering.java
index 44a281b..35a82bb 100644
--- a/src/main/java/com/sosnitzka/taiga/traits/TraitSlaughtering.java
+++ b/src/main/java/com/sosnitzka/taiga/traits/TraitSlaughtering.java
@@ -20,7 +20,6 @@ public class TraitSlaughtering extends AbstractTrait {
         MinecraftForge.EVENT_BUS.register(this);
     }
 
-
     @SubscribeEvent
     public void onMobDrops(LivingDropsEvent event) {
         World w = event.getEntity().getEntityWorld();
diff --git a/src/main/java/com/sosnitzka/taiga/traits/TraitTantrum.java b/src/main/java/com/sosnitzka/taiga/traits/TraitTantrum.java
index 0d70130..d0b6208 100644
--- a/src/main/java/com/sosnitzka/taiga/traits/TraitTantrum.java
+++ b/src/main/java/com/sosnitzka/taiga/traits/TraitTantrum.java
@@ -22,12 +22,11 @@ import slimeknights.tconstruct.library.utils.TinkerUtil;
 
 import static com.sosnitzka.taiga.Blocks.tiberiumOre;
 
+/*
+ *  Collects tiberium, to release it for an explosion
+ */
 public class TraitTantrum extends AbstractTrait {
 
-    /*
-     *  Collects tiberium, to release it for an explosion
-     */
-
     public static float max_charges = 12f;
     public static float max_power = 5;
 
@@ -93,7 +92,6 @@ public class TraitTantrum extends AbstractTrait {
     }
 
     public static class Data {
-
         float amount;
 
         public static Data read(NBTTagCompound tag) {
diff --git a/src/main/java/com/sosnitzka/taiga/traits/TraitWhirl.java b/src/main/java/com/sosnitzka/taiga/traits/TraitWhirl.java
index fd57471..173d88d 100644
--- a/src/main/java/com/sosnitzka/taiga/traits/TraitWhirl.java
+++ b/src/main/java/com/sosnitzka/taiga/traits/TraitWhirl.java
@@ -34,11 +34,7 @@ public class TraitWhirl extends AbstractTrait {
 
     @Override
     public void onUpdate(ItemStack tool, World world, Entity entity, int itemSlot, boolean isSelected) {
-
-        if (entity instanceof FakePlayer || entity.world.isRemote) {
-            return;
-        }
-        if (entity.ticksExisted % TICK_PER_STAT > 0) {
+        if (entity instanceof FakePlayer || entity.world.isRemote || entity.ticksExisted % TICK_PER_STAT != 0) {
             return;
         }
 
@@ -83,7 +79,6 @@ public class TraitWhirl extends AbstractTrait {
                 TagUtil.setEnchantEffect(tool, false);
                 ToolHelper.damageTool(tool, 2 * r, event.getEntityPlayer());
             }
-
         }
     }