diff options
| author | Ben Culkin <scorpress@gmail.com> | 2020-10-06 19:26:52 -0400 |
|---|---|---|
| committer | Ben Culkin <scorpress@gmail.com> | 2020-10-06 19:26:52 -0400 |
| commit | a7a87f682a039d4761112f1dedb9351f3d7a2bbf (patch) | |
| tree | 14688fcc9f8f0d8dee718e213ba5725a7ddc2db1 /base/src/main/java/bjc/utils/misc | |
| parent | 9dd6cd76e45335f5d303456a648c3eca9c5bf930 (diff) | |
Rename exceptions to not use Exception
This renames several of the stock exceptions to remove 'Exception' from
their name. This is something that I don't recall where I picked it up
from, but the idea is that the fact that it is an exception is generally
syntactically obvious. Therefore, you can instead give your exceptions
names which directly state what it wrong, as well as strongly implying
what you can do to fix it.
For instance, if you get a DirectionInvalid, it is apparent what the
issue is (it is less apparent why it is invalid, but that is another
issue, and a discussion for another time)
Diffstat (limited to 'base/src/main/java/bjc/utils/misc')
| -rw-r--r-- | base/src/main/java/bjc/utils/misc/Direction.java | 8 | ||||
| -rw-r--r-- | base/src/main/java/bjc/utils/misc/RelativeDirection.java | 4 |
2 files changed, 6 insertions, 6 deletions
diff --git a/base/src/main/java/bjc/utils/misc/Direction.java b/base/src/main/java/bjc/utils/misc/Direction.java index 6455d8d..cc24b49 100644 --- a/base/src/main/java/bjc/utils/misc/Direction.java +++ b/base/src/main/java/bjc/utils/misc/Direction.java @@ -5,7 +5,7 @@ import java.util.function.Consumer; import org.apache.commons.lang3.text.WordUtils; -import bjc.utils.exceptions.InvalidDirectionException; +import bjc.utils.exceptions.DirectionInvalid; import bjc.funcdata.FunctionalList; import bjc.funcdata.IList; @@ -122,7 +122,7 @@ public enum Direction { case UP: return false; default: - throw new InvalidDirectionException( + throw new DirectionInvalid( "WAT. Somehow ended up with an invalid direction " + this); } } @@ -171,7 +171,7 @@ public enum Direction { case UP: case DOWN: default: - throw new InvalidDirectionException( + throw new DirectionInvalid( "Can't rotate non-cardinal direction clockwise: " + this); } @@ -197,7 +197,7 @@ public enum Direction { case UP: case DOWN: default: - throw new InvalidDirectionException( + throw new DirectionInvalid( "Can't rotate non-cardinal direction counterclockwise: " + this); } diff --git a/base/src/main/java/bjc/utils/misc/RelativeDirection.java b/base/src/main/java/bjc/utils/misc/RelativeDirection.java index 7012377..4239b0d 100644 --- a/base/src/main/java/bjc/utils/misc/RelativeDirection.java +++ b/base/src/main/java/bjc/utils/misc/RelativeDirection.java @@ -3,7 +3,7 @@ package bjc.utils.misc; import java.util.Random; import java.util.function.Consumer; -import bjc.utils.exceptions.InvalidDirectionException; +import bjc.utils.exceptions.DirectionInvalid; import bjc.funcdata.FunctionalList; import bjc.funcdata.IList; @@ -108,7 +108,7 @@ public enum RelativeDirection { case RIGHT: return dir.rotateClockwise(); default: - throw new InvalidDirectionException( + throw new DirectionInvalid( "Attempted to make absolute a direction in a unknown way " + this); } |
